New Design #196
New Design #196
Conversation
…ow sizes and responsiveness + also uniform padding etc + elapsed time
Huh? That is very weird, to be fair since removing the old native title bar I've had weird issues with handling stuff like that primarily since we need to make the container draggable so it can be moved, but that prevents other actions. I will look into this.
Yeh I'll do some experiment in a bit
Sounds like a plan
ahaha we can revert this! |
Not sure how much I changed of it, I don't think that much mainly just the resizing of the window etc. I will have a look! |
I don't think you did TBH. I'm controlling now, will let you know next time someone talks :D |
|
Something doesn't seem to be working with the disconnect logic now. I've long ago disconnected from CRC and TrackAudio still shows me as connected. Also I just realized there are two clocks in the UI, and they aren't showing the same time:
|
The bottom 'clock' is an elapsed time connected, and for the disconnect logic I don't believe I changed anything to do with that, but I will look into it. Regarding the disconnect feature, this will have to be actioned and resolved in a separate PR as I've noticed it seems to be an issue with the Refer to recent commit for QoL improvements and screenshots in the initial post. Opted to use: |
Perhaps add "Connected: " to the front of it? It's totally not clear, I thought one was supposed to be local time and the other zulu time or something. |
I've never had any issues with it until I was testing this PR. Maybe the UI changes caused some timing changes elsewhere? |
src/renderer/src/components/add-station-model/station-modal.tsx
Outdated
Show resolved
Hide resolved
src/renderer/src/components/add-station-model/station-modal.tsx
Outdated
Show resolved
Hide resolved
| </div> | ||
| <div className="d-flex justify-content-center radio-sub-text text-muted text-center"> | ||
| Click the connect button to establish a connection to AFV. | ||
| Click the connect button to establish a connection to the VATSIM audio network. |
There was a problem hiding this comment.
Love the string changes! They're slightly inconsistent though, this one calls it "the VATSIM audio network" and the other one calls it "the VATSIM network". Pick one and use it in both places.
There was a problem hiding this comment.
the VATSIM network refers to FSD, and the VATSIM audio network refers to AFV
There was a problem hiding this comment.
Do users know the difference? Does it matter to them?
|
|
|
Found a bug with the delete button:
Result: All the stations are removed, including UNICOM and GUARD There was no warning this would happen either, I had to disconnect and reconnect to get UNICOM and GUARD back. |
Been playing with this while controlling, I like the new button placement in the title bar. What do you think about swapping the + and edit button positions? For some reason I keep clicking edit when I mean +. My brain seems to expect the most common thing (+) on the far left. Maybe it's just me? |
Well
The React side shouldn't interfere with the Look to see if the updateSessionStatus functions logs |
This time it disconnected fine, but I was in mini-mode and couldn't get out of it. The toggle button would show, but I guess it was layered underneath the error message and wasn't clickable.
TBH, not sure if this is an existing bug or a new one in this branch, but mentioning it for completeness. |
I've fixed that issue so on disconnect it will toggle out of mini mode. The issue with not disconnecting properly once you've disconnected from FSD is purely because of slurper still telling us you're logged in. It's out of our control when it reports what, apparently they have had a few issues over the past days with their hosting provider so maybe the issue is just exacerbated by that. It should normally reflect changes within 10 seconds but can take up to 2 minutes in extreme cases where slurper has missed the deletion of the user from FSD and takes action into its own hands and deletes the user from the cache. |
New Design
This PR outlines the changes made in the
new-designbranchPreview:
Windows:
macOS:
Overview of changes
@mediato prevent users unnecessarily using mini mode when not connectedCustom Title Bar
Removal of the Previous Sidebar
+icon.Click this icon now shows a new modal where the previous features can now be accessed.
I feel like this change still provides the same level of ease to access as it previously did, especially since this action is probably not being used all the time but maybe at the start or a few times during the course of a controlling session.
The last RX element has now been moved to the top right of the main radio stack, and now has a new feature whereby you can show the full list of all receiving stations and their most recently received station callsign by clicking the
which toggles the sidebar on/off. This can also be set in the settings modal to be always displayed or never displayed depending if you want this feature to be shown on start or not.
The radio status element has now been shifted to the focus bar, located at the bottom of the window. It can be used in the same way as before (by clicking on the desired station).
However, force refresh and delete have now been moved and can be accessed by clicking the title bar element button with the
editicon to the right of the clock.This allows you to select multiple stations to refresh/delete at one time, by simply clicking on the radio box and then the relevant title bar element button (located to the right of the edit icon) depending on the action you want to take i.e. delete, refresh. To exit this view, simply click the
editbutton again and you will return to the original view.For reference, previous sidebar:
Improved Screens
When disconnected with no network connection:
When disconnected but have a valid network connection:
When connected but you're an observer or have no radios populated:
Settings Modal Rework
Reworked Mini Mode
Added a new transparency mode, this takes advantage of the OS's native transparent window mode
On Windows:
Transparency mode, with an aircraft talking:
Transparency mode, with an aircraft not talking:
Non-transparent mode:
On macOS:
Transparent mode (macOS light mode):
Transparent mode (macOS dark mode):
With all of these views to exit either resize the bar out of mini mode or simply hover and click the resize button:
Auto focus and Resizing Example